Comments on: Scriptaculous Effect.Squish afterFinish callback fix

By: Scott - 3DM Design

Scott - 3DM Design — Sun, 02 Nov 2008 09:15:36 +0000

Michael-

I’ve been away from Rails for a long time (too long), sorry for the extreme delay in my response.

If I get the chance I’ll take a look at the problem you describe.

By: Michael

Michael — Wed, 20 Aug 2008 10:18:02 +0000

Thanks for the fix, but i thinks the fix kills the other parameter, at least while using through rails, i.e. :duration => 1.5 and such are not evaluated anymore.

By: Scott - 3DM Design

Scott - 3DM Design — Sat, 04 Aug 2007 18:12:18 +0000

Chris-

My first suggestion would be to check your parentheses and brackets carefully. Since I wrote the above fix, the formatting of Effect.Squish code in Scriptaculous seems to have changed a bit.

Upgrading to the current script.aculo.us 1.7.0 this morning, then applying the Object.extend fix above, I was able to get afterFinish to fire after Effect.Squish completed.

Though it may be worth noting that, unlike Squish, Effect.Fold still fires afterFinish just before the element is completely gone.

The other suggestion I can offer is to check your callbacks with simple alert() calls; I say this as the modal alert dialogs essentially freeze script execution while they’re up, and it might be a bit easier to pinpoint when the callback is firing.

Hope that helps!

By: Chris

Chris — Thu, 02 Aug 2007 17:30:00 +0000

I’ve tried your fix, but it still doesn’t work for me. My afterFinish function call is executed before my effect is finished (in this case Squish as you exampled).